feat: additional envars for customization#855
Open
krishnaGajabi wants to merge 1 commit into
Open
Conversation
Signed-off-by: krishnaGajabi <gajbikrishna23@gmail.com>
Comment on lines
+504
to
+510
| # -- RDMA data WR pool size (RDMA only) | ||
| dataWrPoolSize: "4095" | ||
| # -- Max number of in-capsule data size | ||
| inCapsuleDataSize: "4096" | ||
| # -- Max I/O size (bytes) | ||
| maxIoSize: "131072" | ||
| # -- I/O unit size (bytes) |
Member
There was a problem hiding this comment.
Do we need this at seperate places? Why not common?
Contributor
Author
There was a problem hiding this comment.
its more structured this way ie separate setting for rdma and tcp
earlier only setting for tcp were defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addition of following envvars for customization
TCP OPTS
NVMF_TCP_IN_CAPSULE_DATA_SIZE 4096
NVMF_TCP_MAX_IO_SIZE 131072
NVMF_TCP_IO_UNIT_SIZE 131072
RDMA OPTS
NVMF_RDMA_DATA_WR_POOL_SIZE 4095
NVMF_RDMA_MAX_IO_SIZE 131072
NVMF_RDMA_IO_UNIT_SIZE 8192
NVMF_RDMA_IN_CAPSULE_DATA_SIZE 4096
Motivation and Context
Users can custiomize installation according to there environment needs for optimised performance.
How Has This Been Tested?
Deployed chart on a 3 worker node cluster.
Checked the default values
did a in place upgrade and modified tcp opts, changes were reflected
did a in place upgrade after enabling rdma and changes were refelected in daemonset
Types of changes
Checklist: